C++11-ify virtualisation in Nanostack classes #12488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `override` and `final` where appropriate, and eliminate unnecessary `virtual`. Some other C++11 simplifications. Eliminate two unused header files (with no corresponding source files). Reduces code size.
|
@kjbracey-arm, thank you for your changes. |
bulislaw
reviewed
Feb 24, 2020
| #include "MeshInterfaceNanostack.h" | ||
| #include "NanostackEthernetPhy.h" | ||
|
|
||
| class NanostackEMACInterface : public Nanostack::Interface { |
There was a problem hiding this comment.
By this and the other removed class/headers do we make it a breaking change?
There was a problem hiding this comment.
I don't believe there are any breaking changes for "real code" here.
These two header files were a stray remnant of a design that wasn't followed through, and committed by mistake - the corresponding cpp files were missing, so the classes weren't constructible.
It would technically be a breaking change if someone had been including the files for no reason.
mikaleppanen
approved these changes
Feb 26, 2020
0xc0170
approved these changes
Feb 26, 2020
|
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
overrideandfinalwhere appropriate, and eliminate unnecessaryvirtual.Some other C++11 simplifications.
Eliminate two unused header files (with no corresponding source files).
Reduces code size.
Impact of changes
None.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@mikaleppanen